Language of acceptance email

[alex-cstl]

Describe the bug
Our school board is french and we must use french softwares for our users. So our Snipe-IT website is set to be in french ("Default Language" under the "Localization" menu).

By personal preferences, I decided to set my own personal profile to be in english. This should only affect ME and no one else.
But I noticed that if I check out an asset to a user, the check out email (acceptance) the user receives is written in ENGLISH, even though the main website is set to display in FRENCH and the user's profile is also in FRENCH. So, it seems Snipe-IT is relying on the language of MY profile (ENGLISH) to decide what language the email should be sent in, instead of the website's Default Language.

To Reproduce

1. Set Snipe-IT's Default Language to FRENCH (Options > Localization > Default Language > French)
2. Set your own user profile to ENGLISH (User's name > Edit Your Profile > Language > English, US)
3. Check out an asset (with acceptance enabled) to a user

The receiving user should receive an email and this email should be in the language of the sending user.

Expected behavior
I expect Snipe-IT to send check out emails (acceptance) to users using the MAIN and DEFAULT language set in the general preferences (under the Localization menu in the options), which is FRENCH in our case.

Screenshots
Not really applicable

Server (please complete the following information):

• Snipe-IT Version: 4.3.0
• OS: Windows Server 2012, R2
• Web Server: IIS
• PHP Version: 7.1.9

Desktop (please complete the following information):

• OS: Windows 10, 1709
• Browser: Chrome
• Version: 66.0.3359.181

Error Messages
Not applicable

Additional context

• Is this a fresh install or an upgrade?: Upgrade from 4.1.11 to 4.3.0
• What OS and web server you're running Snipe-IT on: See "server" above

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[snipe]

@alex-cstl That's a really good point. We didn't think through that use-case, so thanks for that! (It's interesting that it hasn't come up before, but I suppose most folks typically don't split languages across users that way.

So it seems to me, the emails should go out in the language of the recipient, UNLESS there is no value for the locale of that user, in which case it should be set to the locale in Settings > Localization.

[alex-cstl]

@snipe Indeed, the emails should go out in the language of the recipient. If there is no value, it should use the site's main and default language.
You're right, most users probably don't split languages! And if someone does, they probably don't check out items to other users. I am also not gonna check out many items to users, but still I might and I know other technicians on the road that will, and some of them also think like me: Native language of a software is the way to go for the best comprehension :)

But speaking of the "no value" case, does it really happen? The very first time I went into "Edit Your Profile", the language was already set to French, the same as the web site's default language.

Thanks for looking at the issue and have a great day!

[stale]

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

[snipe]

Looks like the newer version of Laravel will handle this more elegantly. (I had some janky, wacky nonsense staged for develop, but was hoping not to have to use it.)

laravel/framework#25752

[alex-cstl]

Cool! Can't wait to test this out! We're still trailing in the update department... still using Snipe-IT 4.3.0...
I'll check with my tech (Hugo Raymond) if he'll be available to push the upgrade on our server.

As we speak, Hugo is trying to get the "LDAP Sync" working because right now, it crashes while attempting to read and import all of our users from our AD. He has a ticket on-going with your team in order to find a fix. A "work-around" has been found but it is not elegant and it is time-consuming (since we have to sync all of our OU one by one...).

Thanks!

[snipe]

@alex-cstl This update would be in v5, which isn't out yet, so no need to rush :)

[thumperest]

Dear All, we are encountring same issue. I arranged user's language as Romanian, and I am using Turkish. When I send acceptance mail, it sends a Turkish one.
Version: v4.9.4 - build 4437 (master)

[umitsari]

Hello there i was used "Email List of All Assigned " buton to notification for users at Turkish Language. I updated snipe it at Version v6.2.3 - build 11936 (master) then the notification couldn't reach in turkish, only english. I tried the change localization settings and profile settings english to turkish but never changed received mails languages.