Fixed todos with log message

Signed-off-by: snipe <snipe@snipe.net>
snipe · Oct 21, 2024 · 787e651 · 787e651
1 parent ef9b6e3
commit 787e651
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 8 deletions.
diff --git a/app/Http/Controllers/Accessories/AccessoriesFilesController.php b/app/Http/Controllers/Accessories/AccessoriesFilesController.php
@@ -125,7 +125,7 @@ public function show($accessoryId = null, $fileId = null) : View | RedirectRespo
                 }
             }
 
-            // todo
+            return redirect()->route('accessories.show', ['accessory' => $accessory])->with('error',  trans('general.log_record_not_found'));
 
         }
 

diff --git a/app/Http/Controllers/Assets/AssetFilesController.php b/app/Http/Controllers/Assets/AssetFilesController.php
@@ -80,10 +80,11 @@ public function show($assetId = null, $fileId = null) : View | RedirectResponse
 
             }
 
-            return redirect()->back()->with('error',  trans('general.file_not_found_redirect'));
-
+            return redirect()->route('hardware.show', ['hardware' => $asset])->with('error',  trans('general.log_record_not_found'));
         }
 
+        return redirect()->route('hardware.index')->with('error', trans('admin/hardware/message.does_not_exist'));
+
     }
 
     /**

diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php
@@ -17,7 +17,6 @@
 use App\Models\Setting;
 use App\Models\Statuslabel;
 use App\Models\User;
-use Illuminate\Support\Facades\Auth;
 use App\View\Label;
 use Carbon\Carbon;
 use Illuminate\Support\Facades\DB;

diff --git a/app/Http/Controllers/Components/ComponentsFilesController.php b/app/Http/Controllers/Components/ComponentsFilesController.php
@@ -129,7 +129,7 @@ public function show($componentId = null, $fileId = null)
                     return redirect()->route('components.show', ['component' => $component])->with('error',  trans('general.file_not_found'));
                 }
             }
-            // todo
+            return redirect()->route('components.show', ['component' => $component])->with('error',  trans('general.log_record_not_found'));
 
         }
 

diff --git a/app/Http/Controllers/Consumables/ConsumablesFilesController.php b/app/Http/Controllers/Consumables/ConsumablesFilesController.php
@@ -124,7 +124,8 @@ public function show($consumableId = null, $fileId = null)
                     return redirect()->route('consumables.show', ['consumable' => $consumable])->with('error',  trans('general.file_not_found'));
                 }
             }
-            // todo
+            // The log record doesn't exist somehow
+            return redirect()->route('consumables.show', ['consumable' => $consumable])->with('error',  trans('general.log_record_not_found'));
 
         }
 

diff --git a/app/Http/Controllers/Licenses/LicenseFilesController.php b/app/Http/Controllers/Licenses/LicenseFilesController.php
@@ -122,7 +122,8 @@ public function show($licenseId = null, $fileId = null, $download = true)
                 }
             }
 
-           // todo
+            // The log record doesn't exist somehow
+            return redirect()->route('licenses.show', ['licenses' => $license])->with('error',  trans('general.log_record_not_found'));
 
         }
 

diff --git a/app/Http/Controllers/Users/UserFilesController.php b/app/Http/Controllers/Users/UserFilesController.php
@@ -132,7 +132,9 @@ public function show($userId = null, $fileId = null)
                 }
             }
 
-            // todo
+            // The log record doesn't exist somehow
+            return redirect()->route('users.show', ['user' => $user])->with('error',  trans('general.log_record_not_found'));
+
 
             return redirect()->back()->with('error',  trans('general.file_not_found'));
         }

diff --git a/resources/lang/en-US/general.php b/resources/lang/en-US/general.php
@@ -434,6 +434,7 @@
     'alt_uploaded_image_thumbnail' => 'Uploaded thumbnail',
     'placeholder_kit'       => 'Select a kit',
     'file_not_found'        => 'File not found',
+    'log_record_not_found'  => 'No record for that log entry was found.',
     'preview_not_available' => '(no preview)',
     'setup'                 => 'Setup',
     'pre_flight'            => 'Pre-Flight',
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 }
-                // todo
+                return redirect()->route('accessories.show', ['accessory' => $accessory])->with('error',  trans('general.log_record_not_found'));
             }
@@ Expand Down @@