fix: field content cannot be discarded or updated correctly #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of EditableField content do not update when the editing content changes the useEffect of the Editor is not triggered on discard. By adding a resetTrigger this issue has been fixed.
When editing a StreamField the cursor now no longer jumps to the left side which made editing impossible.
schettn
changed the title
schettn
added a commit
that referenced
this pull request
Jul 17, 2021
* fix(editablefield): add resetTrigger to reset the Editor on discard Because of EditableField content do not update when the editing content changes the useEffect of the Editor is not triggered on discard. By adding a resetTrigger this issue has been fixed. * fix(editor): cursor no longer jumps to left side on editing When editing a StreamField the cursor now no longer jumps to the left side which made editing impossible.
kleberbaum
pushed a commit
to getcronit/jaen-v3
that referenced
this pull request
Aug 8, 2024
feat: add lens compatibility with jaen and ZITADEL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
What is the new behavior (if this is a feature change)?
Other information: