Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Improve intel ba1 to implement 1 #77

Merged
merged 6 commits into from
Jun 6, 2020
Merged

Improve intel ba1 to implement 1 #77

merged 6 commits into from
Jun 6, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 6, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

pinterid added 4 commits June 6, 2020 10:21
@pinterid
Update packages.json
f119f45 
The SNEK-Client was published on NPM, so it is no longer installed from local.
@pinterid
Update imports
9802c30 
The imports were updated due to the update of packages.
@pinterid
Update VSCode settings
dab14e7 
The Visual Studio Code settings were updated.
@pinterid
Improve code quality
095ce2c 
The code quality was improved, due to changes in the VSCode settings.
@pinterid pinterid added the enhancement New feature or request label Jun 6, 2020
@pinterid pinterid added this to the v0.1 milestone Jun 6, 2020
@pinterid pinterid self-assigned this Jun 6, 2020
@pinterid pinterid requested a review from schettn June 6, 2020 08:53
@pinterid pinterid linked an issue Jun 6, 2020 that may be closed by this pull request
There should be an adaption to a new client release #73
Closed
schettn
schettn suggested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check

@pinterid
Add prettier settings
2ab73d4 
A file was added to store the settings for prettier.
@pinterid pinterid requested a review from schettn June 6, 2020 09:09
schettn
schettn suggested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after one adjustment

@schettn
Update .prettierrc
abfa8ab 
Add newline at the end of the file
@pinterid pinterid requested a review from schettn June 6, 2020 09:13
schettn
schettn approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@schettn schettn mentioned this pull request Jun 6, 2020
Merged
6 tasks
@schettn schettn merged commit fa6bba8 into implement-1 Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schettn schettn schettn approved these changes

Assignees

@pinterid pinterid

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

There should be an adaption to a new client release
2 participants
@pinterid @schettn