Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Patch 1 to implement 1 #76

Merged
merged 17 commits into from
Jun 3, 2020
Merged

Patch 1 to implement 1 #76

merged 17 commits into from
Jun 3, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 2, 2020 •
edited by schettn
Loading

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

codacy-badger and others added 12 commits April 17, 2020 10:46
@codacy-badger
Add Codacy badge
05af229
@kleberbaum
Merge pull request #39 from codacy-badger/codacy-badge
81793a4 
Add a Codacy badge to README.md
@schettn
Add basic README.md
432d93e 
The basic readme has been added. There are still a few bugs that need to be resolved.
@schettn
Update README.md
382952e 
Refined comments to fit our coding guidline.
Added a missing semicolon.
@schettn
Update README.md
7d78254 
Renamed the database reset function.
@pinterid
Update README.md
e178aa6 
The creators images were updated.
@schettn
Update README.md
1e87ef6 
Update syntax highlithing
@schettn
Update README.md
bc50627 
Fix typo in "Implementation"
@schettn
Update README.md
403aee4 
Add missing new lines
@SignorCC
README.md Update
2f59941 
Improved Readability, Spelling and Phrasing.
@kleberbaum
Update README.md
3827233 
Reverted change due to a request of @schettn.
@kleberbaum
Update README.md
7c22368 
Reverted change due to a request of @kleberbaum.
@pinterid pinterid added the documentation Improvements or additions to documentation label Jun 2, 2020
@pinterid pinterid requested a review from schettn June 2, 2020 11:08
@pinterid pinterid self-assigned this Jun 2, 2020
@pinterid pinterid requested review from Aichnerc and kleberbaum June 2, 2020 11:08
This was linked to issues Jun 2, 2020
There should be no spelling errors in the README #48
Closed
There should be a README for intel #75
Closed
pinterid added 3 commits June 2, 2020 13:12
@pinterid
Fix Codacy
771ddf7 
Fixed the issues marked by Codacy.
@pinterid
Fix Codacy Issues
73c4316 
The issues marked by Codacy were fixed.
@pinterid
Update README.md
091fe21 
The README.md was updated due to an request by codacy.
@pinterid pinterid removed the request for review from kleberbaum June 2, 2020 12:09
schettn
schettn approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check.

@schettn schettn self-requested a review June 2, 2020 17:23
Aichnerc
Aichnerc approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got nothing to add to the review of @schettn

@pinterid
Improve README.md
fc4dbbe 
The README.md was improved due to an request by @schettn .
schettn
schettn approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schettn
Copy link
Member

schettn commented Jun 3, 2020

@pinterid please check my merge.

@pinterid pinterid merged commit 8ce1965 into implement-1 Jun 3, 2020
@pinterid pinterid mentioned this pull request Jun 6, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aichnerc Aichnerc Aichnerc approved these changes

@schettn schettn schettn approved these changes

Assignees

@pinterid pinterid

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There should be a README for intel There should be no spelling errors in the README
6 participants
@pinterid @schettn @Aichnerc @codacy-badger @kleberbaum @SignorCC