Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Improve intel 2 to implement 1 #74

Merged
merged 3 commits into from
May 27, 2020
Merged

Improve intel 2 to implement 1 #74

merged 3 commits into from
May 27, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented May 27, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

schettn added 3 commits May 26, 2020 00:20
@schettn
Fix SQL statement typo
47aa186 
Incorrect capitalisation resulted in the loss of the repository owner. This has now been fixed.
@schettn
Implement new client endpoint structure
e61d39a 
The graphql access is changed now due to changes in the snek
client.
@schettn
Improve code quality
8c0ad5f 
Code quality has been improved
@schettn schettn added bug Something isn't working enhancement New feature or request invalid This doesn't seem right labels May 27, 2020
@schettn schettn added this to the DA Start milestone May 27, 2020
@schettn schettn requested review from kleberbaum and pinterid May 27, 2020 08:43
@schettn schettn self-assigned this May 27, 2020
@schettn schettn requested a review from Aichnerc May 27, 2020 08:43
This was linked to issues May 27, 2020
There is no owner present in repositories #72
Closed
There should be an adaption to a new client release #73
Closed
Aichnerc
Aichnerc approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIGMA 🍑

pinterid
pinterid suggested changes May 27, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a few changes.

@schettn schettn requested a review from pinterid May 27, 2020 09:04
pinterid
pinterid approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@schettn schettn removed the request for review from kleberbaum May 27, 2020 09:05
@pinterid pinterid merged commit 644b488 into implement-1 May 27, 2020
@pinterid pinterid mentioned this pull request Jun 6, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aichnerc Aichnerc Aichnerc approved these changes

@pinterid pinterid pinterid approved these changes

Assignees

@schettn schettn

Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
DA Start
Development

Successfully merging this pull request may close these issues.

There should be an adaption to a new client release There is no owner present in repositories
3 participants
@schettn @Aichnerc @pinterid