Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Add oauth 1 to implement 1 #38

Merged
merged 6 commits into from
Apr 20, 2020
Merged

Add oauth 1 to implement 1 #38

merged 6 commits into from
Apr 20, 2020

Conversation

pinterid
Copy link
Member

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

pinterid added 3 commits April 17, 2020 08:51
@pinterid
Create GuidGenerator
104b001 
The tool for creating random guid string is added.
@pinterid
Create oauth configuration file
f808b57 
The configuration file for the oauth providers is defined.
@pinterid
Create the oauth github provider
e0b3d84 
GitHub oauth request are now handled using the intel.
@pinterid pinterid added the enhancement New feature or request label Apr 17, 2020
@pinterid pinterid added this to the DA Start milestone Apr 17, 2020
@pinterid pinterid requested review from kleberbaum and schettn April 17, 2020 07:03
@pinterid pinterid self-assigned this Apr 17, 2020
schettn
schettn suggested changes Apr 17, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve.

pinterid added 2 commits April 17, 2020 09:31
@pinterid
Update LICENSES
56777f4 
Updated licence info with correct year and
new owner information.
Ref: @dermrsimon
@pinterid
Improve code quality
1259486 
The code quality has been improved due to a request of
@schettn.
@pinterid pinterid requested a review from schettn April 17, 2020 07:32
schettn
schettn approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kleberbaum
kleberbaum suggested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

@pinterid
Improve code quality
53c55d5 
The code quality has been improved due to a request of @kleberbaum.
@pinterid pinterid requested a review from kleberbaum April 20, 2020 09:07
@pinterid pinterid linked an issue Apr 20, 2020 that may be closed by this pull request
There should be a way to provide the oauth GitHub provider from intel #37
Closed
kleberbaum
kleberbaum approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@kleberbaum kleberbaum merged commit c04c72f into implement-1 Apr 20, 2020
@pinterid pinterid mentioned this pull request Jun 6, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

@schettn schettn schettn approved these changes

Assignees

@pinterid pinterid

Labels
enhancement New feature or request
Projects
None yet
Milestone
DA Start
Development

Successfully merging this pull request may close these issues.

There should be a way to provide the oauth GitHub provider from intel
3 participants
@pinterid @kleberbaum @schettn