Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Add intel to implement 1 #17

Merged
merged 9 commits into from
Mar 30, 2020
Merged

Add intel to implement 1 #17

merged 9 commits into from
Mar 30, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented Feb 18, 2020

Now the intel is added. It uses the reducer, client and utils in order to provide
the needed functionality.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

Now the intel is added. It uses the reducer, client and utils in order to provide
the needed functionality.
@schettn schettn added the enhancement New feature or request label Feb 18, 2020
@schettn schettn added this to the Linux Day milestone Feb 18, 2020
@schettn schettn self-assigned this Feb 18, 2020
The code quality has been improved due to the codacy check.
Now the testGet is replaced with a get function which uses the reducer
to get data.
schettn added 4 commits March 9, 2020 21:03
The code quality has been improved by adding documentation.
The code quality has been improved by refine the multiple line comments.
The code quality has been improved by adding documentation.
The code quality has been improved by adding documentation.
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

The code quality has been improved due to a request of
@kleberbaum.
@schettn schettn requested a review from kleberbaum March 30, 2020 12:30
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

The code quality has been improved due to a request of
@kleberbaum.
@schettn schettn requested a review from kleberbaum March 30, 2020 13:26
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@kleberbaum kleberbaum merged commit 26db895 into implement-1 Mar 30, 2020
@pinterid pinterid mentioned this pull request Jun 6, 2020
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants