Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #291 #301

Merged
merged 2 commits into from
Sep 7, 2024
Merged

fix for #291 #301

merged 2 commits into from
Sep 7, 2024

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Sep 1, 2024

fixes #291
fixes #260
fixes #304

This PR ensures that the values in a dropdown are set correctly when the data prop is updated in a callback.

Checked that it worked with all valid formats for the data prop:

1.  an array of strings 
2.  an array of dicts with label and value properties.
3.  an array of dict with group and items as keys where items are one of the previous two types.

@AnnMarieW AnnMarieW requested a review from snehilvj September 3, 2024 09:33
@snehilvj snehilvj merged commit fb2b7b6 into snehilvj:master Sep 7, 2024
@snehilvj
Copy link
Owner

snehilvj commented Sep 7, 2024

Thanks a lot Ann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants