GNOME 45 support #11
GNOME 45 support #11
Conversation
- imports changes - created MyExtension class descended from Extension class - moved enable and disable function into the class - changed timeout_add in enable() property to work - changed supported versions in metadata.json
|
Thank you @jezek for the shared effort. I will look into it. Hope they didn't change much. |
| @@ -112,69 +110,66 @@ function _a11y_mods_update(o, latch_new, lock_new) { | |||
| // Gnome-shell extension interface | |||
| // init, enable, disable | |||
|
|
|||
| function init() { | |||
There was a problem hiding this comment.
To be moved to class constructor
| mods_update_id = seat.connect("kbd-a11y-mods-state-changed", _a11y_mods_update); | ||
| }; | ||
|
|
||
| Main.panel._rightBox.insert_child_at_index(button, 0); |
There was a problem hiding this comment.
Main.panel._rightBox: To be checked after migration, or go with _indicator
|
|
||
| const ExtensionUtils = imports.misc.extensionUtils; | ||
| const Me = ExtensionUtils.getCurrentExtension(); | ||
| import { Extension } from 'resource:///org/gnome/shell/extensions/extension.js'; | ||
|
|
||
| // | ||
| const dbg = false; |
There was a problem hiding this comment.
There few global vars here that may need to be moved inside class
| }; | ||
|
|
||
| Main.panel._rightBox.insert_child_at_index(button, 0); | ||
| timeout_id = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 200, _update); |
|
Just a note. What I found out (from enabled logs), that the |
|
Pardon me my question. You wrote some review comments. I know you also wrote |
|
@jezek Yeah, they are comments for myself. Just to know where I left off and look for what next check. By the way, It seems there are more into Gnome 45. I still couldn't get it to enable or show debug logs. I will test upstream Gnome 45 updated demo, probable do a rewrite step by step to find what broken. |
|
When testing & debugging I'm using the |
|
Hi @sneetsher , it's me again. I've been using this extension, with this PR on Manjaro Linux, even when the latch & lock indications didn't work, cause it's more convenient, to see a modifier is pressed even when latch & lock indications aren't shown. But, after last update, the latch& lock indications started working again. From what I deduce was a bug on gnome side, not a port bug, nor an API change. |
|
@jezek I could get some time to test it.
Thank you very much for effort. I am merging it. |
|
@jezek I tested Ubuntu 23.10 Vanilla installation. It works perfectly too. |
These are minimum changes needed to run on GNOME 45.
Specific changes are described in commit(s).
NOTE: I'm creating this PR as a draft, cause the latch & lock indications are broken when running this PR in GNOME 45 and I still haven't figured out why. I'm a beginner in developing & debugging extensions. If anyone knows how to fix, help is welcome.