Issue #359 reporting legacy input controls on modules methods #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
force-pushed
the
issue_359_reporting_legacy_input_controls_on_modules_methods
branch
from
4c489d9 to
b9ab73b
Compare
|
@thomaslhostis : les tests passent cette fois :) |
thomaslhostis
requested changes
Nov 5, 2018
| //TODO Vérifier si on doit renvoyer le même message que dans le legacy et tester le cas échéant | ||
| }); | ||
|
|
||
| Then("^the request is rejected with a bad request error$", () -> { |
There was a problem hiding this comment.
Cette glue est trop générique et risque de poser problème par la suite si on la réutilise dans un autre scénario
There was a problem hiding this comment.
Ok, discuté à l'oral, je fais le refacto dans mon prochain commit
| @@ -39,7 +39,7 @@ public GetModulesTypes() { | |||
| assertEquals("workingcopy", responseEntity.getBody()[0]); | |||
| }); | |||
|
|
|||
| Then("^a list containing nothing is returned$", () -> { | |||
| Then("^an empty list is returned$", () -> { | |||
There was a problem hiding this comment.
La phrase est mieux formulée mais tout comme ma glue c'est trop générique
There was a problem hiding this comment.
Ok, discuté à l'oral, je fais le refacto dans mon prochain commit
| @@ -64,16 +64,22 @@ public ReleaseModules() { | |||
| } | |||
|
|
|||
| moduleClient.release(moduleBuilder.build(), ModuleIO.class); | |||
| moduleBuilder.withVersionId(1).withIsWorkingCopy(false); | |||
| moduleBuilder.withVersionId(1).withModuleType(ModuleBuilder.RELEASE); | |||
thomaslhostis
approved these changes
Nov 5, 2018
Lucas-C
deleted the
issue_359_reporting_legacy_input_controls_on_modules_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR ne comprend que le partie "contrôles des inputs"