Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class bs-placeholder is no longer set on "default" values in 1.13.10 #2272

Closed
Amunak opened this issue May 7, 2019 · 4 comments
Closed

Class bs-placeholder is no longer set on "default" values in 1.13.10 #2272

Amunak opened this issue May 7, 2019 · 4 comments

Comments

@Amunak
Copy link

Amunak commented May 7, 2019

Somewhere between 1.13.9 and 1.13.10 the bs-placeholder class is no longer set on non-multiple selects. I suspect this change to be the culprit.

I need to style the "default" values differently. My selects looked like this in 1.13.9 (all have the "default" / "initial" value, the first one is a multi-select with nothing selected):

image

Now in 1.13.10 they look like this:

image

I'm not sure whether this is a bug or if it's intended, but I could really use a way to differentiate the "default" values from the user-selected ones.

Or maybe I'm going wrong about this and don't understand how it's supposed to work? x)

@caseyjhol
Copy link
Member

I wasn't able to reproduce this issue. Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case (you can use our preconfigured Plunker), and report back with:

  • your link
  • Bootstrap version
  • bootstrap-select version
  • specific browser and OS details.

@Amunak
Copy link
Author

Amunak commented Oct 28, 2019

Sorry @caseyjhol I didn't get back earlier. Compare this Plunk that's on top of v 1.13.9 and this one that's on top of v1.13.12.

Basically before when you had (I assume?) empty value set, the option (when selected) would be "grayed out" as if it was a "default"/empty option. That's very desirable, IMO, and it disappeared between the versions.

I assume that it's some kind of side effect of how it was written previously, but it was a nice feature. Ideally we could set this style independent of the value perhaps with data attributes or somehting.

@caseyjhol caseyjhol reopened this Oct 28, 2019
caseyjhol added a commit that referenced this issue Oct 29, 2019
…doesn't have a set value, option.value falls back to text anyway) (#2272)
@caseyjhol
Copy link
Member

@Amunak Thanks for the demos. This fix will be available in the next release.

@caseyjhol
Copy link
Member

Released in v1.13.13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants