Add delete dialog for cards #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaier
approved these changes
Jan 19, 2024
|
I wrote a simple Dialog to fulfill the design requirements. |
The requirements in the Ticket APPS-1236 is to implement the dialog operating system compliant. So the simple alert dialog should be fine. Also we discussed already in other cases that we dont use the closing x in the top right corner for android since its not an android standard. So were these changes requested or simply taken from figma? |
|
It's been taken from Figma. :) |
I will remove the closing x then, since it is obsolete and merge afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
On delete click an alert dialog pops up to make sure the user really wants to delete his card.
How to test?
Add a card and then delete it via the details screen