Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image format as raw #914

Closed
wants to merge 1 commit into from
Closed

Set image format as raw #914

wants to merge 1 commit into from

Conversation

dpino
Copy link
Contributor

@dpino dpino commented May 6, 2016

Removes the following warning in qemu0.log:

WARNING: Image format was not specified for '/root/.test_env/qemu-dpdk0.img' 
and probing guessed raw. 
Automatically detecting the format is dangerous for raw images, write operations
on block 0 will be restricted. 
Specify the 'raw' format explicitly to remove the restrictions.

This assumes all images used for benchmarking are in raw format.

@domenkozar
Copy link
Member

domenkozar commented May 11, 2016

While I agree this is annoying, it would be better if we started using qcow2 format as it's more convenient (less space intensive, only takes as much space as actually needed). I think that currently saves ~100MB for copying.

@eugeneia what do you think?

@eugeneia
Copy link
Member

@domenkozar I agree that raw is a waste of space, on the other hand its simple. I think we should support both in case valuable test images in RAW might be provided to us by third parties?

@eugeneia eugeneia self-assigned this May 12, 2016
@domenkozar
Copy link
Member

Sure, setting raw for now is a good step forward to reduce noise in logs 👍

@eugeneia
Copy link
Member

Merging this as currently we only really support RAW images.

eugeneia added a commit that referenced this pull request May 13, 2016
@dpino dpino closed this May 13, 2016
@dpino dpino deleted the set-image-raw branch May 13, 2016 14:19
@eugeneia
Copy link
Member

@dpino I would prefer to keep merged PRs open and their branches alive until the changes actually hit master (at which point they are closed automatically). My reasoning is that if we find new problems on the way from e.g. max-next to master it is convenient to document/solve these issues in the original PR thread.

@dpino
Copy link
Contributor Author

dpino commented May 17, 2016

@Eugenia Sorry, my fault. I was batch closing several remote branches on my fork (git push remote :branch) and I think I closed this one by mistake. I agree with keeping remote branches alive until they are merged.

dpino pushed a commit to dpino/snabb that referenced this pull request Aug 24, 2017
Extract ICMP echo responders to their own apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants