Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import snabblab docs from the wiki into the manual #874

Merged
merged 1 commit into from
May 12, 2016

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Apr 18, 2016

Fixes #864

I've modified it a bit and added minimal Using the lab and Questions sections.

After this is merged, we should update the wiki to point to the manual.

cc @lukego @eugeneia

Name | Purpose | SSH | Xeon model | NICs
---- | ------- | -------- | -------- | ------ | ----
lugano-1 | General use | lugano-1.snabb.co | E3 1650v3 | 2 x 10G (82599), 4 x 10G (X710), 2 x 40G (XL710)
lugano-2 | General use | lugano-1.snabb.co | E3 1650v3 | 2 x 10G (82599), 4 x 10G (X710), 2 x 40G (XL710)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't fqdn in "SSH" column wrong for this and following rows? I guess name and SSH should match up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@plajjan
Copy link
Contributor

plajjan commented Apr 18, 2016

Content wise I think it's good and it addresses #864. I think a link from https://github.com/snabbco/snabb/blame/master/README.md#L91 would be nice as well.

@eugeneia eugeneia self-assigned this Apr 18, 2016
@domenkozar
Copy link
Member Author

domenkozar commented Apr 19, 2016

@plajjan thanks for the review. I've addressed the two comments. @lukego do you agree we should mention snabblab in main README.md?

@domenkozar
Copy link
Member Author

@eugeneia any idea why it's complaining Could not find data file .images/Architecture.png?

@eugeneia
Copy link
Member

eugeneia commented Apr 19, 2016

@domenkozar We messed up the documentation build chain in this release, see #885

@eugeneia
Copy link
Member

@domenkozar You should be able to fix the SnabbDoc failure by merging with master.

@domenkozar
Copy link
Member Author

@domenkozar
Copy link
Member Author

@lukego @eugeneia what's missing here? I'd like to get this into next release so we have something to start with :)

@eugeneia eugeneia merged commit e5f4183 into snabbco:master May 12, 2016
dpino pushed a commit to dpino/snabb that referenced this pull request Jul 31, 2017
Refactor NDP implementation to use FFI style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants