use the CC env var for gcc command in Makefile if available. #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. I would really like for us to rewrite the SIMD checksum code with DynASM rather than GCC SIMD intrinsics. This way we could build with older GCC versions and trust that we get the right code (generated by the DynASM in our tree rather than an uncontrolled version of GCC). One step at a time... DynASM did not support the AVX2 instruction set back when we introduced this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centos 6 ships with an old version of gcc that doesn't support -mavx2. It would be nice for the Makefile to respect CC rather than having to mangle PATH.