-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing toolbox love #861
Merged
Merged
Testing toolbox love #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, thank you. |
@kbara I do the following (my upstream remote is called “snabbco”:
I have the following git aliases in my
|
kbara
pushed a commit
to kbara/snabb
that referenced
this pull request
Apr 29, 2016
dpino
pushed a commit
to dpino/snabb
that referenced
this pull request
Jul 6, 2017
Merge from v2017.07 release candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hijacks #708 and #690 with permission from @petebristow. In short it imports his
Testsink
app asapps.test.match.Match
and uses this app to simplify some replay-type selftest throughout the code base including the selftests for:apps.test.match
(see #727),apps.keyed_ipv6_tunnel.tunnel
,apps.socket.raw
andapps.tap.tap
. Other minor changes include:Source
app to reflect configuration and specify zeroed packet dataapps.test.synth
and fix it to generate proper Ethernet LLC packetsmodest
option forapps.test.match
for “match at least some”-style tests