Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing toolbox love #861

Merged
merged 14 commits into from
May 12, 2016
Merged

Testing toolbox love #861

merged 14 commits into from
May 12, 2016

Conversation

eugeneia
Copy link
Member

@eugeneia eugeneia commented Apr 8, 2016

This PR hijacks #708 and #690 with permission from @petebristow. In short it imports his Testsink app as apps.test.match.Match and uses this app to simplify some replay-type selftest throughout the code base including the selftests for: apps.test.match (see #727), apps.keyed_ipv6_tunnel.tunnel, apps.socket.raw and apps.tap.tap. Other minor changes include:

  • Changed documentation of Source app to reflect configuration and specify zeroed packet data
  • Document apps.test.synth and fix it to generate proper Ethernet LLC packets
  • Introduce modest option for apps.test.match for “match at least some”-style tests

@lukego
Copy link
Member

lukego commented Apr 14, 2016

Upstream needed - @kbara or @wingo?

@kbara kbara self-assigned this Apr 14, 2016
@kbara
Copy link
Contributor

kbara commented Apr 18, 2016

LGTM, thank you.
@lukego : what's the process for merging this, given that the PR is not based against kbara-next - a new PR, or manual merging to kbara-next and closing this?

@eugeneia
Copy link
Member Author

@kbara I do the following (my upstream remote is called “snabbco”:

1=<PRNUMBER>
git fetch snabbco pull/$1/head:pr$1
git merge --no-ff --edit -m "Merge PR #$1 () into $(git rev-parse --abbrev-ref HEAD)" pr$1
git branch -D pr$1

I have the following git aliases in my ~/.gitconfig that make life easy:

[alias]
        pr = "!pr() { git fetch snabbco pull/$1/head:pr$1; }; pr"
        merge-pr = "!merge_pr() { git merge --no-ff --edit -m \"Merge PR #$1 () into $(git rev-parse --abbrev-ref HEAD)\" pr$1 && git branch -D pr$1; }; merge_pr"

@kbara kbara added the merged label Apr 29, 2016
kbara pushed a commit to kbara/snabb that referenced this pull request Apr 29, 2016
@eugeneia eugeneia merged commit 10969b1 into snabbco:master May 12, 2016
dpino pushed a commit to dpino/snabb that referenced this pull request Jul 6, 2017
Merge from v2017.07 release candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants