next: Collected changes for the v2016.04 release #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a clear compilation error on platforms that don't have a 64bit integer size, for example i386. Include a link to porting information so that the user will understand that this is not an arbitrary restriction.
Rationale: people are smart and will figure.
Using the method suggested by Matthew Emerson on Github #752.
…ra-next Have a clear compile-time error on non-64-bit platforms.
This will be used by the lwAFTR.
An initial contributing.md file.
…next Extended documentation guide.
Currently shm.map() will create the file and any containing directories if it does not exist. This is not so great, so I split it into separate open() and create() functions, adapt all callers, and remove map() from the public interface of the shm module.
This commit adds a histogram facility that can record the distribution of different sampled magnitudes. In particular, it is useful for recording distributions of times. Histograms can be mapped into /var/run/snabb, where they can be analyzed by a separate process. This commit also wires up the app.breathe() loop to record latencies for its breath cycles into a well-known file (/var/run/snabb/PID/engine/latency), and wires up "snabb top" to do some basic statistics on this data.
The idea is, there are lots of different kinds of analyses you might want to do on a histogram, and it's too early to canonicalize one of them. Better to build your own on top of iterate(). Also adds tests for iterate().
Previously process-markdown took only an input file argument and printed the result to standard output. Now it takes both an input file and output file argument. The important change is that the '.images' directory containing ditaa images is now created in the same directory as the output file, and that directory is created if necessary. Previously the '.images' was created in the source directory and in practice this was only the right thing if the output file happened to also be in that directory. This was true the past when we were converting foo.src.md -> foo.md but is not true anymore now that we convert foo.md -> obj/foo.md. src/Makefile is updated to reflect this. This also made it possible to drop the Makefile dependency from the manual on the 'snabb' executable, which was an ugly hack intended to ensure that the required directory tree in obj/ had been created somehow. Now the process-markdown script automatically creates any required output directory.
Had used 'readlink -f' to canonicalize input and output paths. However, this fails when the output directory does not exist yet. Now uses 'readlink -m' instead to avoid this problem.
Added note to branches.md that branch 'nix' feeds upstream to 'kbara-next' following ack from kbara on #835.
(also removed a stray conflict marker that I must have missed earlier.)
These scripts were only intended for reference and don't have any test coverage so I do not think they are worth maintaining e.g. to replace 'snabbswitch' with 'snabb' and think about the potential impact of that change. If people want to see working init scripts we could refer them to the NixOS ones that now have CI coverage.
This was added for backwards compatibility when we renamed the binary from 'snabbswitch' to 'snabb' but that was a long time ago now.
Note: This changes the behavior of the program.
This change assumes that the Github repository Igalia/snabbswitch will be renamed to Igalia/snabb. Note: Github will redirect the old name automatically so old links and git checkouts should not be disrupted.
This update has been done manually. There were a few instances where the name 'snabbswitch' should be preserved: links to external sites and handling of older repo versions in snabbdoc.
| || ((cd $(repo_path)/src && git checkout $1 && make obj/doc/snabbswitch.html) \ | ||
| && mv $(repo_path)/src/obj/doc/snabbswitch.html $2) | ||
| || ((cd $(repo_path)/src && git checkout $1 && make obj/doc/snabb.html) \ | ||
| && mv $(repo_path)/src/obj/doc/snabb.html $2) |
There was a problem hiding this comment.
This doesn't work
- for this PR because the old version of SnabbDoc is run
- for other PRs because they might be behind
next
See #856 for a fix targeting next. I think merging that PR should make the CI pass.
eugeneia
added a commit
that referenced
this pull request
Apr 5, 2016
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Jun 30, 2017
Replace missing function 'table_count' for 'table_size'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eugeneia Here is a release candidate for the v2016.04 release. Sorry to deliver it so late!
I have now renamed the Github repository from
snabbswitchtosnabbfor consistency with this release (#852). Hopefully that doesn't break anything: Github seems to have the redirection cases covered.I also made the organization name lowercase (
SnabbCo->snabbco) just to make the canonical version easier to type. Github organization names are not case sensitive so I don't expect trouble here.Looks like the snabbdoc CI is failing perhaps due to script/makefile changes. action needed?