Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make PREFIX work like expected, and use DESTDIR for that #699

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

comotion
Copy link

PREFIX is usually used to indicate installation in /, /usr or /usr/local, while DESTDIR is used when creating packages etc. This is how autocrap does it and a lot of packagers expect this behavior.

@lukego
Copy link
Member

lukego commented Jan 12, 2016

Thanks! Having a nonstandard make install behavior is unfortunate.

One more alternative we should consider: should we drop our install target? I do like the idea of Snabb Switch being a single file that could be (but needn't be) distributed as a binary. If we would want to create symlinks, manpages, etc then this could perhaps be done by a command snabb install [dest] rather than a Makefile.

@eugeneia
Copy link
Member

Assuming make install works otherwise, I think its safe to accept this patch for now and possibly replace make install in another PR. Merged into max-next.

eugeneia added a commit to eugeneia/snabb that referenced this pull request Jan 19, 2016
@eugeneia eugeneia merged commit 56f3464 into snabbco:master Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants