Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: bug fixes collected for next v2015.05 maintenance release #500

Closed
wants to merge 4 commits into from

Conversation

lukego
Copy link
Member

@lukego lukego commented May 24, 2015

No description provided.

lukego added 2 commits May 19, 2015 10:43
There was a mistake in the LuaJIT dependency that would cause a
parallel make to build. (It would expect to find the LuaJIT Makefile
while asynchronously cloning the repo.)

Fixes #471.
@lukego lukego changed the title fixes: bug fixes based on release v2015.05 fixes: bug fixes collected for next v2015.05 maintenance release May 24, 2015
@lukego lukego force-pushed the master branch 3 times, most recently from fb88e97 to 9379c35 Compare June 5, 2015 15:48
@eugeneia
Copy link
Member

eugeneia commented Jun 8, 2015

The title confuses me. Shouldn't it be updated to say 2015.06(.1)? If so should I do some sort of bug fix release tomorrow? If I remember correctly you requested weekly bug fix releases (which is quite frequent, no?).

@lukego
Copy link
Member Author

lukego commented Jun 9, 2015

Hoi :).

Yeah, somewhere in the Git workflow discussion I got it into my head that we should make weekly maintenance releases and just started acting as if this was something we had actually discussed. Excuse me :).

The idea is just to reduce the maximum latency of small but important fixes landing on master. If we only update master once per month then dumb bugs may end up bothering people for weeks longer than necessary. For example, all of our tutorial material says to make -j but that often doesn't work because of a race condition in Makefile. I don't want to regress into the habit of pushing individual fixes like this directly onto master and so "merge fixes onto master on mondays if it happens to contain new commits" seems like a reasonable compromise between "merge right now" or "merge next month".

What do you think?

@lukego
Copy link
Member Author

lukego commented Jun 9, 2015

I am not sure what is the optimal process for bugfix releases.

One idea would be:

  1. If fixes contains no new commits, then skip.
  2. Merge fixes onto master.
  3. Tag as vYYYY.MM.N with the first available N.
  4. Create Github release page with the shortlog.

Could be that we could automate the release process over the longer term so that we humans focus only on having the branches in the right state at the right time. Having humans pushing to master is a bit scary. I actually very briefly screwed up master last week by accidentally pushing a couple of commits and then quickly rebased them away again. I would love to have a process that doesn't permit such goofs.

@eugeneia
Copy link
Member

eugeneia commented Jun 9, 2015

Seems sane to me. So as of now fixes does not contain new commits. I'd suggest we update the title as soon as it does.

@lukego
Copy link
Member Author

lukego commented Jun 9, 2015

To me it seems that fixes does contain new commits: the ones shown above on this PR.

Admittedly this is only one small fix to Makefile (ab563cc ) plus some excessively noisy merge commits. However, that Makefile fix does seem to be needed to make the Getting Started instructions work reliably i.e. for make -j to not fail.

Or do I have a mistake somewhere here?

(Too bad that the lab is offline and so SnabbBot can't run tests.)

@eugeneia
Copy link
Member

eugeneia commented Jun 9, 2015

Oh right I mistakenly did mention that commit in the Kiwi release even though it wasn't in. My bad, fixed.

@lukego
Copy link
Member Author

lukego commented Jun 9, 2015

I should have merged fixes onto next before the release but goofed. have not mastered the multibranch workflow yet.

lukego added a commit to lukego/snabb that referenced this pull request Jun 26, 2015
@lukego
Copy link
Member Author

lukego commented Jun 26, 2015

These landed on next and will be included in the July release.

@lukego lukego closed this Jun 26, 2015
wingo added a commit to wingo/snabb that referenced this pull request Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants