Table app args refactoring #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function Intel82599:new (args) | ||
| args = config.parse_app_arg(args) | ||
| function Intel82599:new (arg) | ||
| conf = config.parse_app_arg(arg) |
There was a problem hiding this comment.
Oh, yes. Good catch! Will have to see if I repeated that mistake.
|
Great hacking! This looks like a solid, bold improvement :-) |
eugeneia
force-pushed
the
app-table-args
branch
from
fcb868b to
0ed39b6
Compare
| function Intel82599:new (args) | ||
| args = config.parse_app_arg(args) | ||
| function Intel82599:new (arg) | ||
| local conf = config.parse_app_arg(arg) |
eugeneia
force-pushed
the
app-table-args
branch
from
0ed39b6 to
cf6089c
Compare
|
Good time to rebase and merge? |
eugeneia
force-pushed
the
app-table-args
branch
from
a0f408a to
6514ce3
Compare
and use table literals instead.
(It's done in `parse_app_arg'.)
|
Sure why not! :) |
Closed
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 5, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 5, 2014
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Nov 5, 2014
…app args refactoring'.
lukego
added a commit
that referenced
this pull request
Nov 5, 2014
[keyed_ipv6_tunnel] Fix regression introduced by #293 URGENT
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 8, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 8, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 11, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 11, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 18, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 18, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 27, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Nov 27, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Dec 23, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Dec 23, 2014
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Jan 11, 2015
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Jan 25, 2015
javierguerragiraldez
added a commit
to javierguerragiraldez/snabbswitch
that referenced
this pull request
Feb 17, 2015
lukego
pushed a commit
that referenced
this pull request
Mar 29, 2016
Clear out Flags in ICMPv4 echo-reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
core.config.parse_app_arga NOOP for tables.parse_app_argeverywhereloadstringwas previously used (also use uniform terminology for app arg handling: An app receives anarg, parses it usingparse_app_argwhich yields aconf.)([[{...}]]):format(...)constructs with table literals across the codebase.Sorry for the big sweep, I felt it was a good point to clean up and unify the code. This might trigger a lot of merge conflicts, so merge this late then I can sort them out myself.