neutron2snabb updates related to L2TPv3 config features #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| error("invalid ipv6 address "..p.." "..v) | ||
| end | ||
| i = i+1 | ||
| local in_addr = ffi.new("uint8_t[4]") |
There was a problem hiding this comment.
Array should be 16 bytes for ipv6
eugeneia
force-pushed
the
neutron2snabb-updates
branch
4 times, most recently
from
64342c3 to
65f4363
Compare
|
|
||
| -- Convert hexadecimal str to string of n bytes padded with null bytes at | ||
| -- the beginning. N defaults to `hexstr:len() / 2'. | ||
| function undump (str, n) |
eugeneia
force-pushed
the
neutron2snabb-updates
branch
2 times, most recently
from
a229166 to
f712ad9
Compare
| ) | ||
| config.local_cookie = lib.hexundump(config.local_cookie, 8) |
There was a problem hiding this comment.
Using hexundump. Throw error if part of input would be ignored (e.g. >16 hex digits.).
Note: hexundump pads from the right, as opposed to what we talked about. Doesn't matter though right?
eugeneia
force-pushed
the
neutron2snabb-updates
branch
from
f712ad9 to
4207e2c
Compare
[keyed_ipv6_tunnel] Accept hex encoded string instead of plain string.
`vif_details.l2tpv3_local_ip'.
lukego
added a commit
that referenced
this pull request
Oct 22, 2014
neutron2snabb updates related to L2TPv3 config features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
neutron2snabbfor new requirements. See bottom of Neutron API Extensions.Also updates
ipv6:pton'to useinet_pton(3).