Partial IPv6 neighbor discovery and various performance tweaks #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header:copy() method of the protocol base class now takes an additional argument "relocate", which, when set to true, will first copy the header to the new location and then make it the active storage of the header such that future manipulations will be reflected in the new location.
The push() method now appends headers to the beginning of the packet buffer of iovec #0. This simplifies the contruction of packets and avoids unnecessary buffer allocations if different apps push to the same packet. However, this change is incompatible to the previous version. All parse methods are now also available for datagrams created from scratch to make the API more consistent and to avoid checks for special cases. A new constructor reuse() allows re-using an instance without putting it on the freelist first.
A new app nd_light provides rudimentary support for address resolution of a pre-configured "next-hop" address. Once the MAC address has been found, it is used for the lifetime of the process.
lukego
added a commit
that referenced
this pull request
Aug 26, 2014
Partial IPv6 neighbor discovery and various performance tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new app apps/ipv6/nd_light that performs rudimentary address resolution for a pre-configured next-hop address. It expects IPv6 packets on its "northbound" link, adds an Ethernet header with the discovered MAC address of the next hop and sends the packet out its "southbound" interface. Packets received from "south" are sent "north" unaltered (i.e. the Ethernet header is not stripped).
This set of commits also includes a few performance boosts. I also changed the semantics of the datagram class' push() method. Headers are now pushed in the "natural" order, i.e. inner-to-outer. This implies that the buffer holding the headers grows downwards. This has the added benefit that now new buffer has to be allocated as long as there is room at the bottom of iovec #0.