lib.poptrie: fix bug where address bits where interpreted in reverse order #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandergall
approved these changes
Feb 27, 2023
Do not maintain offset counter and repeatedly load key and then shift it by offset. Instead load key at beginning and shift it further for each iteration. This way we only have to do load/bswap once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to shift in bits from right to left, thinking that since we are on little endian the addresses are strictly in reverse order. That is not the case! The bytes are swapped but the bits are not! :-)
In the x86 assembly routines we now do
bswapand then shift down bits from right to left.