Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.group_freelist: fix a deadlock #1494

Merged
merged 9 commits into from
Apr 7, 2023

Conversation

eugeneia
Copy link
Member

@eugeneia eugeneia commented Feb 9, 2023

core.group_freelist: fix a deadlock

chunk.sequence was not reloaded on further iterations of the loop.

Use sync.load() to explicitly reload lock-free states.

Panic if we fail to progress after 1000 iterations.

chunk.sequence was not reloaded on further iterations of the loop.

Use sync.load() to explicitly reload lock-free states.

Panic if we fail to progress after 1000 iterations.
@eugeneia eugeneia added the bug label Feb 9, 2023
@eugeneia eugeneia self-assigned this Feb 9, 2023
Copy link
Contributor

@alexandergall alexandergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes but suggest to leave out the deadlock detection.

@eugeneia eugeneia added the release-caspar March 2023 release label Mar 15, 2023
eugeneia added a commit to eugeneia/snabb that referenced this pull request Mar 15, 2023
@eugeneia eugeneia merged commit 7cc72ae into snabbco:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-caspar March 2023 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants