Fixes for regressions in max-next headed for Octarina release #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2022.01.13
…ctions Recent changes ([1], [2], [3]) exposed some previously internal variables and functions from core.packet. This patch restores local bindings for those within core.packet in order to maintain performance. [1] 6174563 (snabbco#1450) [2] ee4e42d (snabbco#1450) [3] 9f0694f (snabbco#1288)
lwAFTR introduced a way to run applications with vmprofile disabled, in a way that branched on engine.vmprofile_enabled on the fast path. This patch cleans this up to only disable the profiler timer, and run setvmprofile unconditionally in both cases. Also removes the duplicate/unused/ineffectual profile option from lib.ptree.worker (profiling can be disabled via lib.scheduling).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression caught while running the benchmark matrix for the Octarina release. See 247ef95 and 5f045e7.
Also includes a fix for a test regression of lwAFTR, see 992a845.