Merge ipsec into next (2018.10) #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a simple ESP 6in6 tunnel app (Tunnel6) to apps.ipsec.esp, and also renames the transport mode app (AES18GCM -> Transport6) to match the naming. The apps.ipsec Linux interoperability test is extended to exercise tunnel mode as well.
...for transport mode when run without an explicit mode.
* add a note that explains performance differences between esp transport and tunnel modes * explicitly return a single value from `decap' in tunnel mode (because of that thing where LuaJIT can trip over this) ...these changes are mostly notes to prevent future selfs from wondering about this again.
This avoids the potentially significant overhead of the lib.protocol.header abstractions during ESP encapsulation by using raw FFI casts instead.
Support the one mandatory ICV length, RFC4106 says: Implementations MUST support a full-length 16-octet ICV, and MAY support 8 or 12 octet ICVs, and MUST NOT support other ICV lengths. Also use the chance to use standard AEAD indentifers to denote the supported AEAD, as per ietf-ipsec@2018-01-08.yang schema.
Saves some cycles during encapsulation by specializing the padding function for power of two alignments.
|
This ready to merge? |
|
Yes this is good to go. |
eugeneia
added a commit
that referenced
this pull request
Jul 17, 2019
Supply cookies w/ correct length in selftest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1381 and #1314
Cc @lukego