Make vhost-user more compatible with new qemu versions #1369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #1103 about using snabb with newer versions of qemu. I encountered the problem myself while testing an app, and got it working with qemu version 2.8.1 with these changes.
The main change is adding support for
VHOST_USER_F_PROTOCOL_FEATURES
to allow queries for protocol extensions. Right now the app just reports not supporting any extensions (supporting extensions is a TODO for the future) and ignores requests to set extensions. It also adds support forVHOST_USER_SET_VRING_ENABLE
which seems to be needed onceVHOST_USER_F_PROTOCOL_FEATURES
is supported.There's also a minor commit that makes it easier to tell when you've used the wrong link names.