Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in tcp fields #1327

Closed
wants to merge 5 commits into from
Closed

fix a bug in tcp fields #1327

wants to merge 5 commits into from

Conversation

xnhp0320
Copy link

tcp.ack is the bit set in tcp flags
while tcp.ack_num should be the ack seq number.

hepeng added 5 commits April 22, 2018 05:09
tcp.ack is the bit set in tcp flags
while tcp.ack_num should be the ack seq number.
parse example
@eugeneia
Copy link
Member

Hi @xnhp0320 :-)

88da49f and ae53f4a look good to me, but the other commits seem out of scope of this PR (especially 3c77fb2 is suspicious, is this for a kernel without hugetlbfs support?) I will cherry pick those two commits if that’s ok?

@eugeneia eugeneia self-assigned this Apr 23, 2018
@xnhp0320
Copy link
Author

xnhp0320 commented May 2, 2018

Oh, sorry!

The other patches are used to make snabb run on our own servers, which seems have a
old version of libc that does not support HUGETLB flags.

You can just use the two patches.

Sorry for the late response.

@eugeneia
Copy link
Member

eugeneia commented May 3, 2018

No problem at all. Merged, thank you!

@eugeneia
Copy link
Member

eugeneia commented Jul 4, 2018

Closing because the requested changes landed in v2018.06

@eugeneia eugeneia closed this Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants