Fix Unix socket EOF handling #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Agricola <bagricola@squiz.co.uk>
lukego
added a commit
that referenced
this pull request
Sep 8, 2017
|
Thanks Ben! Merged. cc @alexandergall who I know has been working on related apps recently and may need to cover this case too. |
dpino
pushed a commit
to dpino/snabb
that referenced
this pull request
Apr 3, 2019
Bump snabb-softwire-v2 revision date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lukego, It looks like during the unix socket rewrite to remove
select()a couple of months ago, the check forlocal bytes = S.read()returning 0 (EOF) was removed, and changed toif not bytes, which only catches errors, as ljsyscall converts -1 to a nil return value, and 0 is true.This means EOF is not caught, so when the socket is terminated from the remote side, the app goes into a loop returning empty allocated packets.
This PR keeps handling for errors (
not bytes) which includes EAGAIN and re-adds thebytes == 0check for EOF - resetting the socket.