Remove check $loginAs vs $user #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there any reasoning about this code? I have hit that when trying to setup qpsmtpd as smarthost and smtp client honestly set loginAs email address from "Mail From" header which obviously is not same as $user. I am bit strugling with this, imho Qpsmtpd core should not decide if client is authorized if loginAs != user. Also this check can't be switched off nor customized via plugin.
|
I vaguely recall that the RFC specifies some relationship between the mail from address and the AUTH address (loginas in the code). Implementing that correctly might take some care (or at least careful reading of the RFC). :-/ It's possible that the system needs to carry around "mail from" and "authenticated user" and use them differently and separately in places where we just use "mail from" now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reasoning about this code? I have hit that when trying to setup qpsmtpd as smarthost and smtp client honestly set loginAs email address from "Mail From" header which obviously is not same as $user.
I am bit strugling with this, imho Qpsmtpd core should not decide if client is authorized if loginAs != user. Also this check can't be switched off nor customized via plugin.