chore: unify logic for metrics collection when any command is executed #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smoya Only applied to |
peter-rr
changed the title
|
@smoya Logic applied to the rest of commands already (just the five ones covered in this POC). |
smoya
reviewed
Dec 21, 2023
smoya
reviewed
Jan 10, 2024
smoya
reviewed
Jan 10, 2024
src/commands/convert.ts
Outdated
| @@ -78,13 +78,13 @@ export default class Convert extends Command { | |||
| if (document !== undefined) { | |||
| metadata = MetadataFromDocument(document, metadata); | |||
| metadata['from_version'] = document.version(); | |||
| this.specFile = await load(filePath); | |||
There was a problem hiding this comment.
I'm concerned about this extra parsing stuff here. Would it make sense to use the original file (specFile var) instead 🤔
There was a problem hiding this comment.
Nevermind, we can revisit all of that in the general PR.
smoya
reviewed
Jan 10, 2024
| @@ -14,7 +14,7 @@ const { writeFile } = promises; | |||
| export enum Optimizations { | |||
| REMOVE_COMPONENTS='remove-components', | |||
| REUSE_COMPONENTS='reuse-components', | |||
| MOVE_TO_COMPONETS='move-to-components' | |||
| MOVE_TO_COMPONENTS='move-to-components' | |||
There was a problem hiding this comment.
Yeah...it was there since a loooong time ago 🙈
smoya
changed the title
|
Changed the title to chore as it is basically a refactor not adding any feature |
smoya
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new methods to unify logic so metrics are collected when any CLI command is executed. All this logic will be implemented in base.ts file and removed from the different command files, except the metadata generated for every different command.