Remove interior mutability from Rng #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but we may want to create a new 1.x release that includes #35 before merging this. |
|
#48 is closed, so I'll merge this. More changes to come. |
Merged
notgull
added a commit
that referenced
this pull request
Jun 9, 2023
- **Breaking:** Remove interior mutability from `Rng`. (#47) - Add a `fork()` method. (#49) - Add a `no_std` mode. (#50) - Add an iterator selection function. (#51) - Add a `choose_multiple()` function for sampling several elements from an iterator. (#55) - Use the `getrandom` crate for seeding on WebAssembly targets if the `js` feature is enabled. (#60)
Pi-Cla
pushed a commit
to Pi-Cla/cargo-mommy
that referenced
this pull request
Jan 3, 2025
In particular fastrand to v2 which requires Rng to be mutable due to smol-rs/fastrand#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes interior mutability from the
Rngtype by removing theCellfrom inside of it and making all of its methods take&mut. This closes #31, and also helps with #36 as a side effect, since we can't callu64()anymore from&self.This is a breaking change, but resolving most of our current issues would require a breaking change as well.
Closes #26
Closes #38