Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Support to specify a service-specific IP address #3

Closed
FraBle opened this issue Mar 11, 2016 · 3 comments
Closed

Support to specify a service-specific IP address #3

FraBle opened this issue Mar 11, 2016 · 3 comments

Comments

@FraBle
Copy link
Contributor

FraBle commented Mar 11, 2016

The registration of a service with Consul can include a service address (docs).
In my use case I have different docker containers, one for Consul (server and agent), one for my Dropwizard service with your dropwizard-consul bundle.
I opened an issue for consul-client by OrbitzWorldwide #106 in which they describe how it is possible to pass the service address as a parameter by using a registration builder.
If dropwizard-consul would adapt this, it would remove the restriction, that the Consul agent and Dropwizard service are running on the same machine (e.g. in Docker scenarios).

@jplock
Copy link
Member

jplock commented Mar 11, 2016

I think I actually had this at one point, then decided to remove it. I'll see what I can do.

@FraBle
Copy link
Contributor Author

FraBle commented Mar 11, 2016

I currently work on a patch/feature for a pull request. I would submit it soon. Maybe you can have a look at it later.

@jplock
Copy link
Member

jplock commented Mar 11, 2016

If you can submit a PR I'll happily review it. Thanks!

jplock added a commit that referenced this issue Mar 12, 2016
@jplock jplock closed this as completed Mar 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants