Modern Gen 1: Important Move Validation Fix & Useless Moves Clause + Minor VaporeMons fixes #9949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please, rebase your PR |
|
I think Double Iron Bash is the only one that needs to be here. Thousand Waves and Thousand Arrows seem to validate fine on the sim right now. |
|
Re-opened this after accidentally closing it while rebasing. Remove TArrows and TWaves validation, as they already work. Also added two minor bug fixes for VaporeMons and a requested "Useless Moves Clause" to MG1 to help with teambuilding. Likely won't be opening another PR for any bugfixes for either mod until after DLC2 releases unless something major comes up. |
Yoshiblaze
changed the title
Yoshiblaze
changed the title
KrisXV
reviewed
Dec 11, 2023
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown
that referenced
this pull request
May 21, 2024
* Update rulesets.ts * Create moves.ts * Update moves.ts * Update formats.ts * Update moves.ts * Update moves.ts * Update rulesets.ts * Update rulesets.ts * Update abilities.ts * Update moves.ts * Update data/mods/moderngen1/rulesets.ts --------- Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick validation fix for some important moves that stopped validating after the previous file clean up for MG1.