Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert index.js and team-validator-async.js to typescript #5987

Merged
merged 11 commits into from
Jan 4, 2020
Merged

Convert index.js and team-validator-async.js to typescript #5987

merged 11 commits into from
Jan 4, 2020

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Nov 17, 2019

No description provided.

Zarel
Zarel reviewed Nov 17, 2019
View reviewed changes
server/index.ts Outdated Show resolved Hide resolved
Zarel
Zarel reviewed Nov 17, 2019
View reviewed changes
server/index.ts Outdated Show resolved Hide resolved
notgull and others added 2 commits November 17, 2019 09:57
@notgull @Zarel
Added FS suggestion
fdb57d0 
Co-Authored-By: Guangcong Luo <guangcongluo@gmail.com>
@notgull
Adding back line of comment
5a9abca
Zarel
Zarel reviewed Nov 17, 2019
View reviewed changes
server/index.ts Outdated Show resolved Hide resolved
notgull and others added 2 commits November 17, 2019 10:57
@notgull @Zarel
Change var in global declaration to const
640ed2c 
Co-Authored-By: Guangcong Luo <guangcongluo@gmail.com>
@notgull
Remove useless @ts-ignore
ffb46cd
Zarel
Zarel reviewed Nov 17, 2019
View reviewed changes
server/index.ts Outdated Show resolved Hide resolved
@thejetou
Copy link
Contributor

thejetou commented Nov 17, 2019 •
edited
Loading

You'll also need to edit the pokemon-showdown script (https://github.com/smogon/pokemon-showdown/blob/master/pokemon-showdown) to refer to .server-dist when starting up the server.

@Zarel
Copy link
Member

Zarel commented Nov 17, 2019

This will also be awkward for the next time we restart the server.

Might as well update to Node 13, right? Right???

@Zarel Zarel added the crashes /hotpatch Will crash a hotpatch command; must only be applied right before a server restart label Nov 17, 2019
@Zarel
Copy link
Member

Zarel commented Dec 12, 2019

Ugh, I can't merge this for today's restart because of conflicts. :(

@thejetou
Copy link
Contributor

Ugh, I can't merge this for today's restart because of conflicts. :(

Thankfully, maintainers can push to branches that are being PR'ed :).

@Zarel
Copy link
Member

Zarel commented Dec 13, 2019

@thejetou Unless it's merging suggestions, because of a GitHub bug. Anyway, I don't have time for complicated fixes during restarts anyway.

@Zarel
Copy link
Member

Zarel commented Jan 4, 2020 •
edited
Loading

@thejetou brings up a good point (in Discord), this might not require a restart. The hotpatchable/unhotpatchable interface doesn't seem to be crossed much here.

@Zarel Zarel merged commit ae28a96 into smogon:master Jan 4, 2020
@AnnikaCodes AnnikaCodes mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zarel Zarel Zarel left review comments

Assignees

@Zarel Zarel

Labels
crashes /hotpatch Will crash a hotpatch command; must only be applied right before a server restart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notgull @thejetou @Zarel