-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert index.js and team-validator-async.js to typescript #5987
Conversation
Co-Authored-By: Guangcong Luo <guangcongluo@gmail.com>
Co-Authored-By: Guangcong Luo <guangcongluo@gmail.com>
You'll also need to edit the |
This will also be awkward for the next time we restart the server. Might as well update to Node 13, right? Right??? |
Ugh, I can't merge this for today's restart because of conflicts. :( |
Thankfully, maintainers can push to branches that are being PR'ed :). |
@thejetou Unless it's merging suggestions, because of a GitHub bug. Anyway, I don't have time for complicated fixes during restarts anyway. |
@thejetou brings up a good point (in Discord), this might not require a restart. The hotpatchable/unhotpatchable interface doesn't seem to be crossed much here. |
No description provided.