-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gen 1 Wrap #10936
Fix Gen 1 Wrap #10936
Conversation
You should be able to at least cancel on a turn that has ended but you wouldn't know it. Would it be able to do that and also have the message display? |
Hm. I see why you would want that, but that's not how we've implemented |
I am willing to work on this then |
Also useful would be someone writing tests for my changes. |
I'm commenting rather than deleting because if we do end up implementing the fight button part, we'll need it.
I can see why simulating pressing the Fight button would be useful. I think I'll leave that for another PR. Probably it would use a flag on the pokemon, separate from |
Source for Wrap defender taking poison damage: https://www.youtube.com/watch?v=qaKw1mWIH28 |
Supersedes #10924
There's no need for complicated Fight button mechanics, we have to deal with the same thing in newer generations and
maybeDisabled
fully covers it.Changes:
maybeDisabled
(move choices can't be cancelled) is in effect for all turns except the last of a 5-turn Wrap