Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sparkling Aria's interaction with Shield Dust #10882

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

andrebastosdias
Copy link
Contributor

Closes #10293
I don't know if there's already a way to determine how many targets were hit. spreadHit doesn't take into account protections, misses, etc.

@KrisXV KrisXV changed the title Sparkling area Fix Sparkling Aria's interaction with an ally's Shield Dust Feb 10, 2025
@andrebastosdias andrebastosdias changed the title Fix Sparkling Aria's interaction with an ally's Shield Dust Fix Sparkling Aria's interaction with Shield Dust Feb 10, 2025
@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Feb 10, 2025

I have another version of the code that doesn't change Sparkling Aria and instead makes use of dustproof, modifying Shield Dust and Covert Cloak:

onModifySecondaries(secondaries, target, source, move) {
	this.debug('Shield Dust prevent secondary');
	const targets = this.getAllActive().filter(p => p.getMoveHitData(move).successful).length;
	return secondaries.filter(effect => !!(effect.self || (effect.dustproof && targets > 1)));
},

The question is whether you think it's worth keeping the dustproof flag. Let me know which one you prefer!

@pyuk-bot
Copy link
Contributor

A relatively less intrusive but more hacky solution could be to give the move two secondaries that both apply the condition and make one of them dustproof. We could use onRestart to detect if the condition is applied twice to the same mon, and if it has been, run the function to cure burns on all afflicted targets.

@andrebastosdias
Copy link
Contributor Author

I think this is the best option. I actually find it pretty weird that we don't track which Pokémon were hit by a move. Once implemented, it's not intrusive at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparkling Aria cures burns from Pokemon with Shield Dust where it shouldn't
2 participants