Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Fix misspelled pokedex IDs #10630

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

larry-the-table-guy
Copy link
Contributor

Discovered while working on #10608

2 in gen5bw1, 1 in gen9ssb.


There are also two entries with inherit: true whose parent mods don't actually have a matching entry:

  • embodyaspect in gen9predlc
  • flygonite in gen9ssb

TBC, the inherit field sticks around at run-time - it never gets removed by loadData in sim/dex.ts because the parent mod has no such entry so you never reach that part of the code.

I couldn't just remove the inherit field because then Typescript complains. I think someone more familiar with sim/ needs to put appropriate values for the fields of those two items. Or maybe they're working as intended. IDK. Just thought I'd let you know.

2 in gen5bw1, 1 in gen9ssb.
@KrisXV
Copy link
Member

KrisXV commented Oct 23, 2024

The embodyaspect is probably an oversight from before it was discovered that there were 4 different embody aspect abilities. Flygonite's inherit can be removed.

@KrisXV KrisXV merged commit 67ad1f5 into smogon:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants