Test: Remove repeated JSON.stringifys in assertSetValidity
#10627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #10616 , I've observed that several seconds are spent building strings in
assertSetValidityfrom./test/random-battles/tools.js.Stats:
249K calls
JSON.stringify''So, you can save up to another 1s by lazily constructing the strings. I decided to pass on that.
3 seconds doesn't seem like a lot right now, but with my local copy of #10616, I'm at ~135 seconds total. So, it adds up. And it's an easy change.
I could not produce similar gains for the other functions in that file, so I left them alone.