Fix Pursuit's interaction with Terastal in NatDex formats. #10624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st if used on a switching enemy * Terastallization should happen before Pursuit.
KrisXV
reviewed
Oct 17, 2024
|
The continue case is needed, yes, because the if is now nested.
…On Thu, Oct 17, 2024, 4:34 PM urkerab ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data/moves.ts
<#10624 (comment)>
:
> + if (action.pokemon === source) {
+ switch (action.choice) {
+ case 'megaEvo':
+ this.actions.runMegaEvo(source);
+ break;
+ // Also a "forme" change that happens before moves, though only possible in NatDex
+ case 'terastallize':
+ this.actions.terastallize(source);
+ break;
+ default:
+ continue;
+ }
Doesn't this change break the case where there's a different action, or
does that never happen?
—
Reply to this email directly, view it on GitHub
<#10624 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWABOWCOT3FQLECQFAMFXLZ4BCRFAVCNFSM6AAAAABQEYN7BGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZWGU2DMMRRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
urkerab
reviewed
Oct 17, 2024
KrisXV
reviewed
Oct 18, 2024
urkerab
reviewed
Oct 18, 2024
Co-authored-by: urkerab <urkerab@users.noreply.github.com>
KrisXV
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when triggering on a target switching out, Pursuit will go first and THEN the user will Terastallize, which is counterintuitive at the very least.