Fixes for close-on-left #3
Conversation
before, the close 'x' and icon for tab would overlap. Now, those tabs will get the same padding as the active tab. Cascades added for `padding: 0` used in base UI Theme.
|
@booc0mtaco Thanks for opening this PR! I originally created this package to make Atom Editor more consistent with built-in OS X applications (e.g. Safari, Finder). Tabs in built-in apps span the full window width. Could you please provide context for the switch to |
|
Oh, in retrospect, it's a pretty naive attempt at getting the tabs to behave like Safari.app . The ideal would be to have the 'x' stay in the same position so you can more easily close multiple files. Safari has more advanced behavior than just fixing the max size, tho. I'm fine with re-submitting to include only the padding/margin change, or dropping this if you want to pluck that part out of the commit. |
|
@booc0mtaco If you wouldn’t mind re-submitting with just the padding/margin change, I’ll merge and publish a new version today. Thanks! Also, I agree: I’d love to adopt the close-button-briefly-stays-fixed-so-multiple-tabs-can-be-closed-quickly feature of built-in apps, but I’m not sure how to replicate that in Atom. |
|
Done! (check the one commit above). |
|
Thanks again @booc0mtaco! This is published as version 0.6.0. |
fixes to address: