Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Tabs stretch after enabling close-on-left #2

Open
raiskila opened this issue Dec 20, 2015 · 2 comments
Open

Tabs stretch after enabling close-on-left #2

raiskila opened this issue Dec 20, 2015 · 2 comments

Comments

@raiskila
Copy link

With the "One Dark" theme enabled (current default), tabs stretch to fill up the entire tab bar after installing this package. The X button is also positioned further from the left edge of the tab than how far it was from right edge of the tab before installing this package

@smockle
Copy link
Collaborator

smockle commented Jul 25, 2016

Hi, I’m sorry for the late response to this!

This package was created to replicate the tab style of built-in OS X applications, which have full-width tabs with left-aligned close buttons. The name "close-on-left" insufficiently describes this, but I’m not sure whether the best solution is to 1. rename this package, 2. split this into two packages, or 3. note this idiosyncrasy in the README. Any recommendations?

More context is included in the discussion for this PR.

@raiskila
Copy link
Author

Hi,

Thanks for the reply! The name of the package was definitely the issue for me then. I may or may not have even read the README at the time, I simply assumed based on the name that the only thing it does is switch the close button to the left side.

I do personally think there should be a package that only does that, and maybe another package that either 1) does this and adjusts the tab with or 2) only adjusts the width (thus the two packages could be installed together to achieve the desired behavior) for those looking for the MacOS like behavior.

Thanks for creating this package, though! I might just use your css as a reference and add the behavior I'm looking for as a customization in my own Atom stylesheet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants