Add host validation to http request tests #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability for the http request tests to model assertions on the host. This can be useful for asserting that the endpoint trait is properly supported, as well as allowing for testing things like AWS clients' ability to resolve hosts based on the service id and region.
kstich
requested changes
Feb 5, 2021
smithy-aws-protocol-tests/model/awsJson1_1/services/machinelearning.smithy
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
validate-host
branch
from
5d7fd6c to
ad1baeb
Compare
kstich
approved these changes
Feb 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for the http request tests to model assertions
on the host. This can be useful for asserting that the endpoint trait
is properly supported, as well as allowing for testing things like
AWS clients' ability to resolve hosts based on the service id and
region.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.