fix(codegen): allow empty string field values for headers #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Sep 20, 2024
| (!Object.getOwnPropertyNames(value).includes("length") || | ||
| value.length != 0) && | ||
| (!Object.getOwnPropertyNames(value).includes("size") || value.size != 0); | ||
| value != undefined && value != null; |
There was a problem hiding this comment.
value != null is enough, since undefined will match
There was a problem hiding this comment.
is it possible to cover this with some unit tests? would be nice to see what cases we are considering
nvllkwng
reviewed
Sep 20, 2024
| (!Object.getOwnPropertyNames(value).includes("length") || | ||
| value.length != 0) && | ||
| (!Object.getOwnPropertyNames(value).includes("size") || value.size != 0); | ||
| value != undefined && value != null; |
There was a problem hiding this comment.
- we should keep
!==as we did before for null and undef checks - Are we not worried about
value.sizeanymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5444
Description of changes:
allows headers to have empty field values.
for more details, relevant RFC: https://www.rfc-editor.org/rfc/rfc9110.html#section-5.5
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.