Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/keepalive #1310

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix/keepalive #1310

merged 1 commit into from
Jun 17, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jun 17, 2024

related to aws/aws-sdk-js-v3#6144

moves the keep alive support check to the first FetchHttpHandler constructor call.

this avoids doing work in the module load phase now that fetch support is enabled in Node.js

@kuhe kuhe requested review from a team as code owners June 17, 2024 15:48
@kuhe kuhe requested a review from kstich June 17, 2024 15:48
@kuhe kuhe force-pushed the fix/keepalive branch 2 times, most recently from aa6e308 to f2837e9 Compare June 17, 2024 15:50
@kuhe kuhe merged commit fedce37 into smithy-lang:main Jun 17, 2024
9 of 10 checks passed
@kuhe kuhe deleted the fix/keepalive branch June 17, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants