fix: set noEmitHelpers=false #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from an issue that was discovered in JSv3 aws/aws-sdk-js-v3#5752.
There is no effect on the Smithy NPM packages code distributions by this change, since the issue does not apply here.
Explanation
This fix can prevent future issues. The configuration
noEmitHelpers=truewas copied over from JSv3 a long time ago, but is incorrect. It is only meant to be true when the application provides global implementations of the TS helper functions, but we do not do that. We useimportHelpers=true.At least in our current version of TypeScript, the set of importable helpers does not fully cover the set of emit-able helpers, so with both config fields set to true, there is potential to have some helper functions both unimplemented and unimported.