Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check runtime exports to generate esm annotation list #1147

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 19, 2024

Related to aws/aws-sdk-js-v3#5694

Esbuild generates an incomplete list of export names for ESM compatibility. This change checks the dist file itself in runtime for what names are exported, and then annotates them into the file.

@kuhe kuhe requested review from a team as code owners January 19, 2024 16:52
@kuhe kuhe merged commit 2b1bf05 into smithy-lang:main Jan 19, 2024
7 checks passed
@kuhe kuhe deleted the fix/dist-cjs branch January 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants