Skip to content

Commit

Permalink
fix(node-http-handler): omit setting cache setting on request init wh…
Browse files Browse the repository at this point in the history
…en using default value (#1411)

* Fixes #1407
  • Loading branch information
nicksrandall authored Sep 20, 2024
1 parent 71b163b commit 0d5ab1d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/good-cheetahs-wait.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/fetch-http-handler": patch
---

Omit setting cache setting on request init when using default value
6 changes: 5 additions & 1 deletion packages/fetch-http-handler/src/fetch-http-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,12 @@ export class FetchHttpHandler implements HttpHandler<FetchHttpHandlerConfig> {
headers: new Headers(request.headers),
method: method,
credentials,
cache: this.config!.cache ?? "default",
};
// cache property is not supported in workerd runtime
// TODO: can we feature detect support for cache and not set this property when not supported?
if (this.config?.cache) {
requestOptions.cache = this.config.cache;
}

if (body) {
requestOptions.duplex = "half";
Expand Down

0 comments on commit 0d5ab1d

Please sign in to comment.