Add Credentials to aws-config
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into aws-config-credentials
jdisanti
approved these changes
Aug 31, 2021
| // `LazyCachingCredentialsProvider` will load credentials if it doesn't have any non-expired | ||
| // credentials cached. See the docs on the builder for the various configuration options, | ||
| // such as timeouts, default expiration times, and more. | ||
| let sts_provider = LazyCachingCredentialsProvider::builder() |
There was a problem hiding this comment.
What do you think about making it possible to directly construct the AssumeRoleProvider so that programmatic (without a profile file) access of assumed role credentials is easy?
There was a problem hiding this comment.
I think that's a good goal (although there are actually several different variants to handle, so probably a TODO item)
There was a problem hiding this comment.
Just to leave a breadcrumb: awslabs/aws-sdk-rust#3
rcoh
force-pushed
the
aws-config-credentials
branch
from
df04b41 to
3922d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#655
This config migrates
aws-auth-providersintoaws-config. This enables a relatively seamless instantiation of service clients.Description
AsyncProvideCredentialstoProvideCredentialsProvideCredentialsto be a newtype futureaws-auth-providerstoaws-configaws-auth-providersNoCredentialswhen a service builder is constructed directly.ProvideCredentialsnow also includes aDebugboundArc<dyn ProvideCredentials>with the newtypeSharedCredentialsProviderin the property bagTesting
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.